[PATCH xkbcomp] symbols: increase the warning level for shortening a key type

Peter Hutterer peter.hutterer at who-t.net
Sun Nov 8 20:41:07 PST 2015


On Fri, Nov 06, 2015 at 10:37:44AM +0100, Benno Schulenberg wrote:
> 
> On Fri, Nov 6, 2015, at 08:25, Peter Hutterer wrote:
> > On Thu, Nov 05, 2015 at 04:21:14PM +0100, Benno Schulenberg wrote:
> > > A patch that actually fixes the bug that causes this warning to printed
> > > was proposed and reviewed a year ago:
> > >   http://lists.x.org/archives/xorg-devel/attachments/20140911/e675c15a/attachment.patch
> > > 
> > > It was first posted here;
> > >   http://lists.x.org/archives/xorg-devel/2014-September/043751.html
> > > 
> > > Any chance of applying it still?
> > 
> > looks like there was some disagreement on the details between Ran and you,
> > ending with Ran's comment of "if you send a patch I will review it :)".
> 
> That comment was about another change that I was thinking of making.
> The change that you are now proposing to make, in fact.  :)
> 
> > I don't think there was an updated version sent, was there?
> 
> The updated version, with Ran's review tag in it, is the one I linked to.
> 
> See Ran's comment ("Looks good") about the revised version in:
>   http://lists.x.org/archives/xorg-devel/2014-September/043838.html

oh, there's an attachment. that's why I didn't see it at first.
I pushed the patch now, thanks

   f909259..bf4d7d0  master -> master

Cheers,
   Peter




More information about the xorg-devel mailing list