[PATCH] Do nothing when there are no platform devices

walter harms wharms at bfs.de
Wed Sep 9 07:09:24 PDT 2015



Am 09.09.2015 14:58, schrieb Marcin Juszkiewicz:
> Probably not best solution yet but closer.
> 
> commit dd1aa1f2fb9d91d766e020ac5c2cf474ce951788
> Author: Marcin Juszkiewicz <mjuszkiewicz at redhat.com>
> Date:   Wed Sep 9 14:53:51 2015 +0200
> 
>     xserver: ignore boot_vga on AArch64
>     
>     AArch64 machines firmware does not initialize graphics output so
>     boot_vga is not set.
>     
>     Without this patch Xserver needs to be told where gfx card is by
>     providing BusId entry in xorg.conf file.
>     
>     Signed-off-by: Marcin Juszkiewicz <mjuszkiewicz at redhat.com>
> 
> diff --git a/hw/xfree86/common/xf86platformBus.c b/hw/xfree86/common/xf86platformBus.c
> index f1e9423..9dd56ec 100644
> --- a/hw/xfree86/common/xf86platformBus.c
> +++ b/hw/xfree86/common/xf86platformBus.c
> @@ -136,10 +136,14 @@ platform_find_pci_info(struct xf86_platform_device *pd, char *busid)
>      if (info) {
>          pd->pdev = info;
>          pci_device_probe(info);
> +#ifndef __aarch64__
>          if (pci_device_is_boot_vga(info)) {
> +#endif
>              primaryBus.type = BUS_PLATFORM;
>              primaryBus.id.plat = pd;
> +#ifndef __aarch64__
>          }
> +#endif


I do not now if the patch is working oe not but to reduce the #if forrest

#ifndef __aarch64_
          if (pci_device_is_boot_vga(info))
#endif
          {
		primaryBus.type = BUS_PLATFORM;
		primaryBus.id.plat = pd;
 	  }


more over i would change the architecture depending part into something
more functional like IGNORE_BOOT_VGA


note i am not the maintainer, just my 2 cents

re,
 wh

>      }primaryBus.id.plat = pd;
>      pci_iterator_destroy(iter);
>  
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list