[pull request] xwayland fixes

Adam Jackson ajax at redhat.com
Mon Sep 21 10:56:44 PDT 2015


On Mon, 2015-09-21 at 13:15 -0400, Olivier Fourdan wrote:
> Hi Adam,
> 
> Could you please pull from the following git tree some fixes for
> Xwayland (some are quite old).

At this point in the 1.18 cycle we're meant to be locking down ABI,
which means this series can't quite go in as-is:

> @@ -212,6 +212,7 @@ typedef struct _GrabRec {
>   */
>  typedef struct _SpriteRec {
>      CursorPtr current;
> +    Bool invalidated;
>      BoxRec hotLimits;           /* logical constraints of hot spot */
>      Bool confined;              /* confined to screen */
>      RegionPtr hotShape;         /* additional logical shape constraint */

Breaks SpriteRec layout.

> @@ -524,6 +527,7 @@ typedef struct _Screen {
>      UnrealizeCursorProcPtr UnrealizeCursor;
>      RecolorCursorProcPtr RecolorCursor;
>      SetCursorPositionProcPtr SetCursorPosition;
> +    InvalidateCursorProcPtr InvalidateCursor;
>  
>      /* GC procedures */
>  

Breaks ScreenRec layout.

For both of the above it would be sufficient to move the new slots to
the end of the struct, since neither one is something a driver would
ever allocate or see as an array.

- ajax


More information about the xorg-devel mailing list