[PATCH:xf86-video-sis] Fix arguments for miSetPointerPosition.

Connor Behan connor.behan at gmail.com
Wed Sep 30 13:52:13 PDT 2015


On 13/09/15 05:29 PM, Thomas Klausner wrote:
> For the call for the API between versions 5 and 13.
> ---
>  src/sis_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sis_driver.c b/src/sis_driver.c
> index 854cb54..c1d26f3 100644
> --- a/src/sis_driver.c
> +++ b/src/sis_driver.c
> @@ -9397,7 +9397,7 @@ SISMergedPointerMoved(SCRN_ARG_TYPE arg, int x, int y)
>  #elif GET_ABI_MAJOR(ABI_XINPUT_VERSION) >= 13
>  	miPointerSetPosition(inputInfo.pointer, Absolute, x, y);
>  #elif GET_ABI_MAJOR(ABI_XINPUT_VERSION) >= 5
> -	miPointerSetPosition(inputInfo.pointer, x, y);
> +	miPointerSetPosition(inputInfo.pointer, &x, &y);
>  #else
>  	UpdateCurrentTime();
>  	miPointerAbsoluteCursor(x, y, currentTime.milliseconds);
I'm pretty sure the calls for ABI versions between 13 and 15 also need
the "&". For example, in the
http://cgit.freedesktop.org/xorg/xserver/tree/?id=81cfe44b1ed0de84ad1941fe2ca74bebef3fc58d
tree, hw/xfree86/common/xf86Module.h says ABI_XINPUT_VERSION is 14. But
mi/mipointer.c still has miPointerSetPosition() taking pointers to integers.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150930/297fdcc2/attachment.sig>


More information about the xorg-devel mailing list