[PATCH xserver 2/4 v3] xwayland: add a server sync before repeating keys

[Olivier Fourdan]

Hi Daniel,

Thanks for the feedback!

----- Original Message -----
> Hi,
> 
> On 9 March 2016 at 09:31, Olivier Fourdan <ofourdan at redhat.com> wrote:
> > @@ -748,6 +783,9 @@ seat_handle_capabilities(void *data, struct wl_seat
> > *seat,
> >              ActivateDevice(xwl_seat->keyboard, TRUE);
> >          }
> >          EnableDevice(xwl_seat->keyboard, TRUE);
> > +        master = GetMaster(xwl_seat->keyboard, MASTER_KEYBOARD);
> > +        if (master)
> > +            master->key->xkbInfo->checkRepeat = keyboard_check_repeat;
> 
> This needs to be done on xwl_seat->keyboard as well: both devices
> generate events. You can see this with 'xinput test'.

keyboard_check_repeat() operates on the xwl_seat itself, so I reckon it works for both devices.

If I explicitely set the callback function for both devices as you suggest, key repeat becomes completely erratic as both devices share the same xwl_seat, so doing it on the master device alone seems to work better.

Cheers,
Olivier