[PATCH xserver] xwayland: Fix compiler warning in GLAMOR Xv

Adam Jackson ajax at nwnk.net
Mon Apr 18 15:18:47 UTC 2016


On Sat, 2016-04-16 at 01:52 +0100, Emil Velikov wrote:

> Is there a specific reason behind the (seemingly) duplicate Xv/XvMC
> code in xserver - {Encoding, Format, Image...}Rec. Seems to me that
> the top Xext should be the sole one, although xf86, xwin, xwayland and
> kdrive have their (almost) identical versions.
> 
> I'd imagine it's a case of people lacking the time to folding things
> up or is that an intentional split ?

More the former. Many of the di/dd splits in the code seem to me like
they start from very conservative assumptions about what "the hardware"
might be capable of, and hardware just doesn't vary that much.

If someone did want to drain that particular swamp, it'd be nice to see
Xv support in Xnest first, to ensure that the ensuing refactor is still
expressive enough to handle servers without pixmaps.

- ajax


More information about the xorg-devel mailing list