[PATCH xserver 2/4] xfree86: remove unused path from the LoadModule API

Emil Velikov emil.l.velikov at gmail.com
Mon Apr 18 21:25:19 UTC 2016


On 18 April 2016 at 22:08, Adam Jackson <ajax at nwnk.net> wrote:
> On Mon, 2016-04-18 at 21:44 +0100, Emil Velikov wrote:
>> On 18 April 2016 at 21:43, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> >
>> > On 18 April 2016 at 20:50, Adam Jackson <ajax at nwnk.net> wrote:
>> > >
>> > > On Sun, 2016-04-17 at 21:07 +0100, Emil Velikov wrote:
>> > > >
>> > > > Similar to its little brothre - LoadSubModule. Currently all call sites
>> > > > provide NULL anyway ;-)
>> > > You can be more aggressive here, subdirlist and patternlist are also
>> > > always NULL. And errmin is almost entirely pointless, I can only find
>> > > one place that it disambiguates.
>> > >
>> > Sure I have patches for that as well. Here is my line of thought
>> >
>> > Step 1 - make LoadModule and LoadSubModule alike
>> > Step 2 - nuke subdirlist, subdirlist, subdirlist and subdirlist, from
>> > both APIs ;-)
>> >
>> Oops the list should be subdirlist, patternlist, options and modreq
>
> I'm not sure options can go? It seems to be the only reasonable way to
> get configuration into, say, the vnc module.
>
Looking at it again... I've misread (and butchered) it. Yes it cannot go :-\

Emil


More information about the xorg-devel mailing list