[PATCH] Avoid 10x7 heuristic, handled by server

Julien Cristau jcristau at debian.org
Tue Apr 26 13:49:12 UTC 2016


On Tue, Apr 26, 2016 at 14:09:24 +0200, Stefan Dirsch wrote:

> On Tue, Apr 26, 2016 at 12:58:55PM +0200, Julien Cristau wrote:
> > On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote:
> > 
> > > From: Frederic Crozat <fcrozat at suse.com>
> > > 
> > > Remove the 10x7 heuristic, since the server has equivalent code now.
> > > Instead, disable "acceleration" under qemu, since taking the hypercall
> > > trap is really quite expensive and you're better off doing noaccel.
> > > (Fedora)
> > > ---
> > >  src/alp_driver.c | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > What does "the 10x7 heuristic" refer to?  Maybe
> > http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/tree/cirrus-1.2.0-qemu.patch?id=b726ffdd66d6aaf49c64f999eb2c004e1d5041fb
> > which is an earlier version of this patch?
> 
> Wow! Thanks for the pointer. Honestly I never understood the comment, since
> today I've seen the original patch the first time. ;-) LOL!
> 
> > (Also, authorship seems wrong, if you took this patch from Fedora, it
> > should be attributed to ajax afaict:
> > http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/log/cirrus-1.2.0-qemu.patch
> 
> Ok. Since the patch we're using is obviously no longer related to Ajax'
> original one I keep it attributed to Frederic. Unless he or you're vetoing. I
> could add "very loosely based on Ajax' patch" though.
> 
The patch you're using today seems to be pretty much the same as
http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/tree/cirrus-1.2.0-qemu.patch?id=daccd1c8174623500eddfa297d8ea76a86d3c5d9

Cheers,
Julien


More information about the xorg-devel mailing list