[PATCH libICE] Enable visibility annotations

[Yury Gribov]

On 04/29/2016 04:31 PM, Emil Velikov wrote:
> Hi Jon,
>
> On 28 April 2016 at 17:38, Jon Turney <jon.turney at dronecode.org.uk> wrote:
>> On 28/04/2016 14:59, Emil Velikov wrote:
>>>
>>> Are you sure that think this is correct ? Afaict things should work,
>>> despite that xserver sets SYMBOL_VISIBILITY=no.
>>>
>>> Jon, any ideas why xserver disables -fvisibility=hidden ? Should we
>>> remove that line or there's something subtle that requires the
>>> behaviour ? For example: relying on symbols that are not marked as
>>> exported or alike.
>>>
>>>  From past (ancient) experiences and reading the wiki correctly,
>>> combining -fivisiblity=hidden + dllimport/dllexport should work fine ?
>>
>>
>> As far as I recall, the issue was simply that if you use -fvisibility=hidden
>> for a PE/COFF target, gcc will warn 'visibility attribute not supported in
>> this configuration; ignored' on every single symbol declaration with default
>> visibility, which is really annoying...
>>
> Is there a way to toggle the visibility on global scale - or it
> defaults to hidden automatically when dllimport/dllexport is detected
> ?
> Any ideas why the latter are not included in xproto ?

FYI gcc -shared seems to export all symbols regardless of dllexport 
annotations of -fvisibility settings. You seem to need dlltool magic to 
actually hide symbols in dlls (again, I'm not proficient with MinGW/Cygwin).

> Thanks
> Emil
>
>