[PATCH xserver] os: don't re-remove an already removed fd

Peter Hutterer peter.hutterer at who-t.net
Thu Aug 11 06:48:40 UTC 2016

On Wed, Aug 10, 2016 at 10:52:03PM -0700, Keith Packard wrote:
> Peter Hutterer <peter.hutterer at who-t.net> writes:
> > wacom does. and yes, it needs to get fixed in the driver now that it
> > doesn't work anymore but meanwhile not crashing is still good.
> Right, wondering if simply not registering the duplicate FD would also work?

that's the plan for the driver, but for now the current behaviour is a
change to what used to work. And it's a bit confusing too -
xf86AddEnabledDevice() takes a pInfo, not just an fd. So it looks like it
works on a per-device level and we should emulate that behaviour as best as
we can. Right now you can pass two different pInfos in and then you get to
bet whether you remove the same device twice or not.


More information about the xorg-devel mailing list