[PATCH xserver] dix: Avoid writing uninitialized bytes in deliverPropertyNotifyEvent

Keith Packard keithp at keithp.com
Sat Aug 13 16:06:57 UTC 2016


Make sure the whole event is initialized, instead of leaving the pad
bytes unset.

Signed-off-by: Keith Packard <keithp at keithp.com>
---
 dix/property.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/dix/property.c b/dix/property.c
index bde2af8..fa4da2d 100644
--- a/dix/property.c
+++ b/dix/property.c
@@ -110,10 +110,12 @@ deliverPropertyNotifyEvent(WindowPtr pWin, int state, Atom atom)
 {
     xEvent event;
     UpdateCurrentTimeIf();
-    event.u.property.window = pWin->drawable.id;
-    event.u.property.state = state;
-    event.u.property.atom = atom;
-    event.u.property.time = currentTime.milliseconds;
+    event = (xEvent) {
+        .u.property.window = pWin->drawable.id,
+        .u.property.state = state,
+        .u.property.atom = atom,
+        .u.property.time = currentTime.milliseconds,
+    };
     event.u.u.type = PropertyNotify;
     DeliverEvents(pWin, &event, 1, (WindowPtr) NULL);
 }
-- 
2.8.1



More information about the xorg-devel mailing list