[PATCH xserver] Pass ClientPtr to FlushCallback

Adam Jackson ajax at nwnk.net
Mon Aug 15 18:07:33 UTC 2016

On Tue, 2016-08-02 at 17:53 +0900, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
> This change has two effects:
> 1. Only calls FlushCallbacks when we're actually flushing data to a
>    client. The unnecessary FlushCallback calls could cause significant
>    performance degradation with compositing, which is significantly
>    reduced even without any driver changes.
> 2. By passing the ClientPtr to FlushCallbacks, drivers can completely
>    eliminate unnecessary flushing of GPU commands by keeping track of
>    whether we're flushing any XDamageNotify events to the client for
>    which the corresponding rendering commands haven't been flushed to
>    the GPU yet.
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

I can imagine a better approach to flush management, but we're honestly
pretty far from implementing even what little the GLX spec asks for.
This looks like an entirely reasonable change on its own and the
improvements it enables are worthwhile, so that's progress at least.

remote: I: patch #102509 updated using rev b380f3ac51f40ffefcde7d3db5c4c149f274246d.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   92b3cd3..b380f3a  master -> master

- ajax

More information about the xorg-devel mailing list