[PATCH xserver] Fix Xorg -configure not working anymore

Adam Jackson ajax at redhat.com
Tue Aug 16 16:36:59 UTC 2016


On Mon, 2016-08-08 at 14:53 +0200, Hans de Goede wrote:

> Adding support for the xf86Configure code to xf86platformBus.c
> is non trivial and since we advise users to normally run without
> any Xorg.conf at all not worth the trouble.

I'm guessing "non-trivial" is used here in the "I don't like this code
so I don't want to touch it" sense. Which, fair enough I guess, but I
really don't think it's that difficult to add. Like, pretty sure one
conditional at the bottom of doPlatformProbe would be about all you
need.

Also: "we advise users not to use xorg.conf" is a bad meme, can we
please stop. It is still the config file. If you need it, you need it.

> However some users still want to use Xorg -configure to generate a
> template config file, this commit implements a minimal fix to make
> things work again for PCI devices by skipping the platform
> probe method when xf86DoConfigure is set.

This means you'll fail to generate a config file under Hyper-V, where
the fbdev device is platform not pci.

- ajax


More information about the xorg-devel mailing list