[PATCH xserver v3] glamor: Handle bitplane in glamor_copy_fbo_cpu

Eric Anholt eric at anholt.net
Sat Aug 20 04:53:09 UTC 2016

Michel Dänzer <michel at daenzer.net> writes:

> On 18/08/16 11:09 PM, Alex Deucher wrote:
>> On Thu, Aug 18, 2016 at 5:42 AM, Michel Dänzer <michel at daenzer.net> wrote:
>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>> This can significantly speed up at least some CopyPlane cases, e.g.
>>> indirectly for stippled fills.
>>> v2:
>>> * Make temporary pixmap the same size as the destination pixmap
>>>   (instead of the destination drawable size), and fix coordinate
>>>   parameters passed to fbCopyXtoX and glamor_upload_boxes. Fixes
>>>   incorrect rendering rendering with x11perf -copyplane* and crashes
>>>   with the xscreensaver phosphor hack.
>>> v3:
>>> * Make the change a bit more compact and hopefully more readable by
>>>   re-using the existing src_* locals in the bitplane case as well.
>>> Reported-by: Keith Raghubar <keith.raghubar at amd.com>
>>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> Thanks, Alex.
> Eric, what do you think about this patch? It can speed up clients
> hitting this path by more than an order of magnitude, but it's not
> exercised by XTS, and I currently don't have the bandwidth to change that.

Yeah, this is the example I was thinking of when I was saying "if we're
going to be writing code to accelerate things, we'd better have tests
for it", exemplified by the v2 changes.  However, I won't be getting
around to writing the tests either, so we're in a bit of a bind.

I think, ultimately, getting glamor's performance up to expected matters
the most, even if people suffer rendering failures along the way because
we're bad at testing.  So,

Acked-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160819/b0698bbb/attachment.sig>

More information about the xorg-devel mailing list