[PATCH xserver] composite: Fix repaint of borders (v2)

Keith Packard keithp at keithp.com
Tue Dec 6 21:51:11 UTC 2016


Adam Jackson <ajax at redhat.com> writes:

> When going from border width zero to a non-zero border width, the
> Composite extension is informed via the ConfigNotify callback. The
> call-chain looks like this: compConfigNotify -> compReallocPixmap ->
> compSetPixmap -> TraverseTree -> compSetPixmapVisitWindow. However, at
> this time, pWindow->borderWidth was not yet updated. Thus, HasBorder()
> is false and the window border will not be repainted.
>
> To fix this, thread the new bw through to the window visitor, and
> inspect that rather than HasBorder(). For all the other callers the
> border does not change size, so we can pass pWin->borderWidth instead.

Yeah, that's a nicer version of this patch.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20161206/50130cb4/attachment.sig>


More information about the xorg-devel mailing list