[PATCH xserver 06/11] dmx: Remove scrnDefDrawables to remove a use of MAXFORMATS

Keith Packard keithp at keithp.com
Sat Dec 10 17:12:17 UTC 2016


Adam Jackson <ajax at redhat.com> writes:

> We only kinda needed this for the CreateGC screen hook, because that
> gets called only with the GC itself so we don't have a drawable already
> on the backend to point to. But since we know the GC depth, we can just
> create a 1x1 pixmap at that depth on the fly instead.

I'd say just create an array indexed by depth for these pixmaps instead
and leave them around; having to create a pixmap every time you create a
GC seems a bit expensive to me, even if it is only DMX.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20161210/e145e0c9/attachment.sig>


More information about the xorg-devel mailing list