[PATCH xserver 3/3] present: Call present_restore_screen_pixmap from present_set_abort_flip

Chris Wilson chris at chris-wilson.co.uk
Fri Feb 19 12:10:51 UTC 2016

On Fri, Feb 19, 2016 at 11:39:12AM +0900, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
> After present_set_abort_flip, the screen pixmap will be used for all
> screen drawing, so we need to restore the current flip pixmap contents
> to the screen pixmap here as well.
> Improves flashing / stutter e.g. when something like a popup menu appears
> on top of a flipping fullscreen window or when switching out of
> fullscreen.
> Note that this means present_set_abort_flip now relies on screen->root
> being non-NULL, but that's already the case in other present code.

It is true that we cannot schedule a flip without screen->root (though
present_check_flip would crash rather than reject the call).
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Chris Wilson, Intel Open Source Technology Centre

More information about the xorg-devel mailing list