[PATCH xserver 2/3] present: Factor code for restoring screen pixmap out of present_unflip

Keith Packard keithp at keithp.com
Fri Feb 19 05:31:19 UTC 2016

Michel Dänzer <michel at daenzer.net> writes:

Here's another review, now that I've more carefully looked at the other
two patches.

> +    if (!flip_window || !flip_pixmap)
> +        return;

In the original code, this didn't abort the operation entirely...

This operation would have been skipped:

> +    present_set_tree_pixmap(flip_window, flip_pixmap, screen_pixmap);

But this operation would not:

> +    present_set_tree_pixmap(screen->root, NULL, screen_pixmap);

Reading the rest of the code, I can't find a case which could call this
with a null flip_window or flip_pixmap; perhaps it would be better to
stick an assert that they are both set at the top of this function?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160218/6e67d0a8/attachment.sig>

More information about the xorg-devel mailing list