[PATCH xserver 2/3] present: Factor code for restoring screen pixmap out of present_unflip (v2)

Keith Packard keithp at keithp.com
Fri Feb 26 05:12:35 UTC 2016

Michel Dänzer <michel at daenzer.net> writes:

> On 22.02.2016 18:16, Michel Dänzer wrote:
>> From: Michel Dänzer <michel.daenzer at amd.com>
>> The following fix will use the refactored function.
>> The logic in the refactored function is slightly simplified, exploiting
>> the fact that this function is only ever called with a valid flip
>> pixmap.
>> v2: Assert that flip_pixmap is non-NULL instead of testing and bailing
>>     on NULL, preserve test for flip_window being non-NULL before calling
>>     present_set_tree_pixmap for it (Keith Packard)
>> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> (v1)
>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> Keith, does this look good?

Yup, I saw that Chris had reviewed it, so I didn't bother responding,
but I read through it all.

Reviewed-by: Keith Packard <keithp at keithp.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160225/66583b0f/attachment.sig>

More information about the xorg-devel mailing list