[PATCH 7/8] glamor: add core profile support to EGL glamor. (v2)

[Michel Dänzer]

On 19.01.2016 16:02, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> This breaks ABI unfortunately as we have to pass the core profile
> info from the egl part of glamor to the glamor part of glamor.

Drop this paragraph.


> @@ -798,12 +807,21 @@ glamor_egl_init(ScrnInfoPtr scrn, int fd)
>                                  KHR_surfaceless_opengl);
>  #endif
>  
> +#ifndef GLAMOR_GLES2
>      glamor_egl->context = eglCreateContext(glamor_egl->display,
>                                             NULL, EGL_NO_CONTEXT,
> -                                           config_attribs);
> -    if (glamor_egl->context == EGL_NO_CONTEXT) {
> -        xf86DrvMsg(scrn->scrnIndex, X_ERROR, "Failed to create EGL context\n");

Might be nice to keep something like

    if (glamor_egl->context == EGL_NO_CONTEXT) {
       xf86DrvMsgVerb(scrn->scrnIndex, X_WARNING, 4,
                      "Failed to create EGL OpenGL core profile context\n");
    }


> -        goto error;
> +                                           config_attribs_core);
> +#else
> +    glamor_egl->context = NULL;

s/NULL/EGL_NO_CONTEXT/ ?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer