[PATCH] glx: don't force version == 2.0 for ES2 GLX context creation

Adam Jackson ajax at nwnk.net
Wed Jan 20 12:14:41 PST 2016

On Wed, 2016-01-20 at 14:53 -0500, Ilia Mirkin wrote:

> That said, if you believe the only thing that needs to be done to (on
> the X server side) support ES1 with GLX is to remove that return,
> more than happy to send another patch that always lets it succeed.

I think letting any ES version succeed (in this check) will work fine.
For direct contexts it doesn't matter since the choice of draw API only
affects the client side. For indirect contexts, later on, we do:

>     /* There is no GLX protocol for desktop OpenGL versions after 1.4.  There
>      * is no GLX protocol for any version of OpenGL ES.  If the application is
>      * requested an indirect rendering context for a version that cannot be
>      * satisfied, reject it.
>      *
>      * The GLX_ARB_create_context spec says:
>      *
>      *     "* If <config> does not support compatible OpenGL contexts
>      *        providing the requested API major and minor version,
>      *        forward-compatible flag, and debug context flag, GLXBadFBConfig
>      *        is generated."
>      */
>     if (!req->isDirect && (major_version > 1 || minor_version > 4
>                            || profile == GLX_CONTEXT_ES2_PROFILE_BIT_EXT)) {
>         return __glXError(GLXBadFBConfig);
>     }

Granted someone wanting both GLX and fixed-function GLES might
reasonably be considered to have made poor life choices, but from
xserver's perspective there's no reason it shouldn't work in a direct

- ajax

More information about the xorg-devel mailing list