[PATCH 2/2] release.sh: Don't quit on dry runs if tarball already uploaded

Peter Hutterer peter.hutterer at who-t.net
Wed Jan 20 23:16:14 PST 2016


On Wed, Jan 20, 2016 at 02:46:39PM -0800, Bryce Harrington wrote:
> From: Bryce Harrington <bryce at bryceharrington.org>
> 
> When doing practice runs of the script, we aren't going to be uploading
> anything, so don't treat it as a fatal error if the tarball is already
> uploaded, as this may hide potential subsequent issues that the user
> should know about.
> 
> Signed-off-by: Bryce Harrington <bryce at bryceharrington.org>
> ---
>  release.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/release.sh b/release.sh
> index 0a1c607..ac6cb10 100755
> --- a/release.sh
> +++ b/release.sh
> @@ -594,6 +594,8 @@ process_module() {
>  	if [ $? -eq 0 ]; then
>  	    if [ "x$FORCE" = "xyes" ]; then
>  		echo "Warning: overwriting released tarballs due to --force option."
> +	    elif [ "x$DRY_RUN" = "xyes" ]; then
> +		echo "Warning: tarball $tar_name is already uploaded to $hostname."
>  	    else
>  		echo "Error: tarball $tar_name already exists on $hostname. Use --force to overwrite."
>  		cd $top_src
> -- 
> 1.9.1

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net> for both

Cheers,
   Peter


More information about the xorg-devel mailing list