[PATCH xserver] FlushAllOutput: Only call FlushCallbacks when actually flushing data

Peter Harris pharris at opentext.com
Mon Jul 11 16:32:17 UTC 2016


On 2016-07-08 16:33, Keith Packard wrote:
> Adam Jackson <ajax at nwnk.net> writes:
> 
>> Still not cool with committing code that we _know_ will break a
>> supported platform.
> 
> Oh, right, windows. Hrm. Suggestions welcome, but I suspect the only
> workable solution will be to write some windows-specific code that does
> the wait for multiple objects thing. We can't use select because the
> fd_set data structure, while 'poll-like', has a fixed number of fds, and
> we can't use poll because it's broken.

The number of fds in fd_set isn't really fixed. FD_SETSIZE is user
controlled, so I can't imagine a problem with massaging fd_set into C99
variable-length-array form:

typedef struct xfd_set {
        u_int fd_count;
        SOCKET  fd_array[];
} xfd_set;

and reallocing to taste.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the xorg-devel mailing list