[PATCH xserver] xfree86: Fix fallback driver sort order for Xorg -configure (v2)

Keith Packard keithp at keithp.com
Tue Jul 12 20:53:21 UTC 2016


Adam Jackson <ajax at redhat.com> writes:

> The intent here was that fallback drivers would be at the end of the
> list in order, but if a fallback driver happened to be at the end of the
> list already that's not what would happen. Rather than open-code
> something smarter, just use qsort.
>
> Note that qsort puts things in ascending order, so somewhat backwardsly
> fallbacks are greater than native drivers, and vesa is greater than
> modesetting.
>
> v2: Use strcmp to compare non-fallback drivers so we get a predictable
> result if your libc's qsort isn't stable (Keith Packard)

Sorry, I wasn't clear at all. I'm assuming that the original driver list
is relevant, and that what we want to do is pull the 'fallback' drivers
out of the list and stick them at the end (in a sorted order). If that
isn't right, then this patch looks great. If it is true, then we should
figure out some way of preserving the order?

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160712/f0edda70/attachment-0001.sig>


More information about the xorg-devel mailing list