[PATCH xserver] modesetting: resubmit dirty rects on EINVAL

[Michael Thayer]

Reviewed-by: Michael Thayer <michael.thayer at oracle.com>

And successfully tested by one user who experienced buggy behaviour 
without the patch.

On 15.07.2016 17:28, Adam Jackson wrote:
> This error code can mean we're submitting more rects at once than the
> driver can handle. If that happens, resubmit one at a time.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>   hw/xfree86/drivers/modesetting/driver.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver.c
> index 262a899..2de16f6 100644
> --- a/hw/xfree86/drivers/modesetting/driver.c
> +++ b/hw/xfree86/drivers/modesetting/driver.c
> @@ -515,6 +515,17 @@ dispatch_dirty_region(ScrnInfoPtr scrn,
>
>           /* TODO query connector property to see if this is needed */
>           ret = drmModeDirtyFB(ms->fd, fb_id, clip, num_cliprects);
> +
> +        /* if we're swamping it with work, try one at a time */
> +        if (ret == -EINVAL) {
> +            for (i = 0; i < num_cliprects; i++) {
> +                if (drmModeDirtyFB(ms->fd, fb_id, &clip[i], 1) == -EINVAL)
> +                    break;
> +            }
> +            if (i == num_cliprects)
> +                ret = 0;
> +        }
> +
>           free(clip);
>           DamageEmpty(damage);
>       }
>

-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister 
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher