[PATCH] xdm: Add headers for implicitly declared function

Alan Coopersmith alan.coopersmith at oracle.com
Fri Jul 29 16:05:35 UTC 2016


On 07/29/16 02:40 AM, Alive 4ever wrote:
> On Mon, Jul 25, 2016 at 03:46:38PM -0700, Alan Coopersmith wrote:
>> On 07/24/16 07:52 PM, Alive 4ever wrote:
>>> Added headers needed to suppress implicit function declaration error.
>>> This fixes build on gcc 6.1.1 and clang 3.8.0.
>>
>> Those headers are not the same on all OS'es - you'd need to check for existence
>> of the headers in configure.ac and then use those #ifdef's instead.
>>
>>> +# include <bsd/unistd.h>
>>> +#include <bsd/stdlib.h>
>>> +#include <bsd/unistd.h>
>
> I've sent a revised patch to make configure.ac check 'bsd/unistd.h' and
> 'bsd/stdlib.h' existence and add HAVE_BSD_UNISTD_H and HAVE_BSD_STDLIB_H
> definition to properly detect 'libbsd' presence and use it if it's
> found.
>
> Please have a review at my revised patch.

Yes, I saw, I'll try to get to it soon.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list