[PATCH xserver] build: Enable vidmode independently from Xorg

Emil Velikov emil.l.velikov at gmail.com
Thu Mar 3 23:18:55 UTC 2016


Hi Rui,

On 3 March 2016 at 21:00, Rui Matos <tiagomatos at gmail.com> wrote:
> This allows building Xwayland without Xorg and still include the
> vidmode extension.
>
> Signed-off-by: Rui Matos <tiagomatos at gmail.com>
> ---
>  configure.ac | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index c166841..d157b22 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1509,6 +1509,14 @@ if test "x$XDMAUTH" = xyes; then
>         fi
>  fi
>
> +if test "x$XF86VIDMODE" = xauto; then
> +       PKG_CHECK_MODULES(XF86VIDMODE, $VIDMODEPROTO, [XF86VIDMODE=yes], [XF86VIDMODE=no])
> +fi
> +if test "x$XF86VIDMODE" = xyes; then
> +       AC_DEFINE(XF86VIDMODE, 1, [Support XFree86 Video Mode extension])
Was about to say "we are missing the PKG_CHECK_MODULES" only to recall
that the packages are checked in one via the *MODULES variables.

Although ... we are using PKG_CHECK_MODULES in the autodetection
(pretty much everywhere) where it should be PKG_CHECK_EXISTS. Can you
fix the patch to use the latter ? I'll send a couple of patches that
cover the remaining s/CHECK_MODULES/CHECK_EXISTS/ and another one that
removes the unneeded PKG_CHECK_MODULES.

With the suggested change, this patch is
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

-Emil


More information about the xorg-devel mailing list