[PATCH xserver 2/2] xwayland: Correctly detect whether posix_fallocate exists

Julien Cristau jcristau at debian.org
Tue Mar 8 11:47:47 UTC 2016


On Tue, Mar  8, 2016 at 18:32:27 +0800, Jonas Ådahl wrote:

> On Tue, Feb 23, 2016 at 08:54:47AM +0800, Jonas Ådahl wrote:
> > On Fri, Feb 19, 2016 at 11:53:46AM +0100, Julien Cristau wrote:
> > > On Fri, Feb 19, 2016 at 15:08:13 +0800, Jonas Ådahl wrote:
> > > 
> > > > We had HAVE_POSIX_FALLOCATE checks, but no such macros were ever
> > > > defined anywhere. This commit makes it so that this macro is defined if
> > > > the posix_fallocate is detected during configure.
> > > > 
> > > > Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> > > 
> > > Hi,
> > > 
> > > any reason not to do the check unconditionally and put the define in
> > > dix-config.h?
> > 
> > The only reason is that the function checked is only used by the
> > xwayland ddx. It could just as well be added to dix-config.h if that is
> > preferred.
> 
> So any opinions regarding this? Should the macro be moved ddx/ or not?
> 
I still think putting it in dix-config is simpler and I can't think of
any downsides.

Cheers,
Julien


More information about the xorg-devel mailing list