[PATCH xserver 0/9] double frees in AddResource failure paths

Adam Jackson ajax at nwnk.net
Tue Mar 8 15:21:46 UTC 2016


On Tue, 2016-03-08 at 00:30 +0100, Rémi Cardona wrote:
> Le 07/03/2016 23:20, Julien Cristau a écrit :
> > Hi,
> > 
> > prompted by Adam's recent fixes for unchecked AddResource, I've been
> > looking at the failure paths, and found a number of places where it
> > looks like we're freeing things twice (once as part of AddResource
> > itself calling the destroy function for the resource, and once in the
> > caller).  Plus more unchecked AddResource calls in xvmc and dri3.
> > 
> > Cheers,
> > Julien
> 
> Caveat emptor: I didn't check that CreateNewResourceType was called with
> a correct deleteFunc. With that said, the patches look correct to me:
> 
> Reviewed-by: Rémi Cardona <remi at gentoo.org>

remote: I: patch #76082 updated using rev 119d5c0e2f800737c949ef760c5fe25d963200bf.
remote: I: patch #76083 updated using rev ac97fb2b804809c39b12fe0032d96fb076657258.
remote: I: patch #76078 updated using rev 59b9c3d5e4bf05aeaaac2ee4ea12c301a67aae2c.
remote: I: patch #76080 updated using rev 164753f158e78f615f903467bfd234d7c58244ef.
remote: I: patch #76079 updated using rev acf263df81ad6813e0233033610fb44521cab1b4.
remote: I: patch #76085 updated using rev d0c1a5bc61a3d151f2234aa3820862f16c0f00c7.
remote: I: patch #76084 updated using rev 054f80717812d4781741cd05393623fe6f6c627f.
remote: I: patch #76086 updated using rev 4217db89ecd480fda2ee74fecba06c6713c2a0f0.
remote: I: patch #76081 updated using rev 2be527b1d4ce2b0412c4484539a8c9607645ec6d.
remote: I: 9 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   a2c3c34..2be527b  master -> master

- ajax


More information about the xorg-devel mailing list