[PATCH 1/2] present: fail flipping if we have any slave outputs.

Adam Jackson ajax at nwnk.net
Fri Mar 11 18:49:51 UTC 2016


On Thu, 2016-03-03 at 14:25 -0800, Keith Packard wrote:
> Dave Airlie <airlied at gmail.com> writes:
> 
> > 
> > Due to the way present currently works, we don't ever
> > check with the secondary adapters if we can flip at all.
> > 
> > We shouldn't flip if the secondary adapters are attached
> > to the pixmap currently, however using the current check_flip
> > callback isn't possible as it passes the Window to the driver
> > (something we shouldn't be doing), so the slave driver can never
> > get it's own screen ptr back.
> > 
> > For now to fix the problem just block flips if we have any
> > slaves configured. We can fix the ABI up later, but this
> > fix can be backported to stable.
> > 
> > Signed-off-by: Dave Airlie <airlied at redhat.com>
> This doesn't obviously do this check when the output slave list is
> modified, but looking at the code, it seems that
> xf86RandR14ProviderSetOutputSource mashes the root clip a couple of
> times to make sure the outputs all get repainted, and that should end up
> calling ClipNotify on any flip window. So,
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>

remote: I: patch #72999 updated using rev 47bc7fcaa567b0d9e2627b4a21b112e96f81725b.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   3169487..47bc7fc  master -> master

- ajax


More information about the xorg-devel mailing list