[PATCH xserver] glamor: Make context current in glamor_pixmap_fbo_cache_put

Eric Anholt eric at anholt.net
Fri Mar 11 18:49:55 UTC 2016


Michel Dänzer <michel at daenzer.net> writes:

> From: Michel Dänzer <michel.daenzer at amd.com>
>
> Without this, we may be manipulating the context of another screen.
>
> In a system with two GPUs using glamor, this fixes lots of
>
> (EE) glamor256: GL error: GL_INVALID_OPERATION in glBindTexture(non-gen name)
>
> spew since 0b4c0c75 ('glamor: Replace "finish access" shader with texture
> swizzling').
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> ---
>
> BTW, is fbo->tex guaranteed to be non-0 here?

Yeah, you shouldn't be able to have a glamor_pixmap_fbo without ->tex.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160311/a157935e/attachment.sig>


More information about the xorg-devel mailing list