[PATCH xserver 5/8] xquartz/glx: Error out for MakeContextCurrent(draw != read)

Jeremy Huddleston Sequoia jeremyhu at gmail.com
Wed Mar 23 04:21:16 UTC 2016


With the change to !=:
Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

> On Mar 21, 2016, at 13:29, Adam Jackson <ajax at redhat.com> wrote:
> 
> CGL doesn't have a way to express this directly, unlike EGL WGL and GLX.
> It might be implementable, but it's never actually worked, and it's a
> fairly niche feature so we're better off throwing an error if someone
> attempts it.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
> hw/xquartz/GL/indirect.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/hw/xquartz/GL/indirect.c b/hw/xquartz/GL/indirect.c
> index 54c9073..c0648c4 100644
> --- a/hw/xquartz/GL/indirect.c
> +++ b/hw/xquartz/GL/indirect.c
> @@ -387,6 +387,9 @@ __glXAquaContextMakeCurrent(__GLXcontext *baseContext)
> 
>     GLAQUA_DEBUG_MSG("glAquaMakeCurrent (ctx 0x%p)\n", baseContext);
> 
> +    if (context->base.drawPriv !+ context->base.readPriv)
> +        return 0;
> +
>     if (attach(context, drawPriv))
>         return /*error*/ 0;
> 
> -- 
> 2.5.0
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4465 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160322/dcbdc378/attachment-0001.bin>


More information about the xorg-devel mailing list