[PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

Simon Thum simon.thum at gmx.de
Thu May 19 10:53:07 UTC 2016


Hi Keith!

Just saw this patch while I glossed over the input threading patches. 
Glad to see them land after all these years! But anyway:

On 05/18/2016 11:03 PM, Keith Packard wrote:
> -    /* X is very likely to have the wrong idea of what the actual cursor
> -     * sprite is, so in order to force updating the cursor lets set the
> -     * current sprite to some invalid cursor behind its back so that it
> -     * always will think it changed to the not invalid cursor.
> -     */
> -    mipointer = MIPOINTER(master);
> -    mipointer->pSpriteCursor = (CursorPtr) 1;
> +    miPointerInvalidateSprite(master);

Maybe the MIPOINTER macro def is a candidate for removal, too?

Cheers,

Simon




More information about the xorg-devel mailing list