PATCH: Add xorg-xserver 1.19 support to tigervnc

Eric Engestrom eric.engestrom at imgtec.com
Mon Oct 3 16:57:51 UTC 2016


On Mon, Oct 03, 2016 at 05:59:33PM +0200, Hans de Goede wrote:
> Hello tigervnc devs,
> 
> As part of updating Fedora to xserver 1.19 I've written
> a tiger vnc patch to make tigervnc work with xserver 1.19.
> 
> Since xserver 1.19 switches from select to poll the changes
> are non trivial and require some #ifdef-s. The new code is
> a lot cleaner then the old code though, which is good.
> 
> And with server 1.19 the os/WaitFor.c changes are no longer
> necessary.
> 
> Attached is a tigervnc-1.7.0 patch, as well as a patch
> to apply to the xserver sources to patch in the tigervnc
> ext and hw/vnc dir into the buidlsys.
> 
> Regards,
> 
> Hans

[snip]

> --- tigervnc-1.7.0/unix/xserver/hw/vnc/xorg-version.h	2016-09-08 12:31:18.000000000 +0200
> +++ tigervnc-1.7.0.new/unix/xserver/hw/vnc/xorg-version.h	2016-10-03 10:27:53.721116357 +0200
> @@ -50,8 +50,10 @@
>  #define XORG 117
>  #elif XORG_VERSION_CURRENT < ((1 * 10000000) + (18 * 100000) + (99 * 1000))
>  #define XORG 118
> +#elif XORG_VERSION_CURRENT < ((1 * 10000000) + (19 * 100000) + (99 * 1000))
> +#define XORG 119
>  #else
> -#error "X.Org newer than 1.18 is not supported"
> +#error "X.Org newer than 1.18 is not supported"

This seems like a git bug? (Not the first time I've seen this in a patch)
There doesn't seem to be a difference here, but it's obvious the change
was means to be s/18/19/.
This will just need to be done manually while applying this patch :)


More information about the xorg-devel mailing list