[Spice-devel] [PATCH xf86-video-qxl] Fix crash caused by attempting to access the screen pixmap before it is created

Christophe Fergeau cfergeau at redhat.com
Tue Oct 4 13:51:24 UTC 2016


Hey Hans,


On Tue, Oct 04, 2016 at 02:08:13PM +0200, Hans de Goede wrote:
> qxl_resize_primary_to_virtual() was using pScrn->pScreen != NULL to check
> if createScreenResources has been called. But starting with xserver 1.19
> pScrn->pScreen is non NULL even before createScreenResources is called,
> causing an invalid access to the screenPixmap in
> qxl_resize_primary_to_virtual().
> 
> This commit fixes this.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1381045
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Yes, this was changed in the xserver by
69b782aa75bc06f11b8f9b532d5213f252c4c6c4
"xfree86: Set pScrn->pScreen before driver ScreenInit is called"


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20161004/aa415e5f/attachment.sig>


More information about the xorg-devel mailing list