[PATCH v2 libXi 2/2] XListInputDevices: don't touch ndevices in case of error

Emil Velikov emil.l.velikov at gmail.com
Fri Oct 14 13:28:55 UTC 2016


On 13 October 2016 at 04:58, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> We used to always set *ndevices to the number of devices returned by the
> server. This magically worked because we pretty much never returned an error
> except on faulty server or library implementations. With 19a9cd60 we now have
> more chances of getting an error, so the polite thing is to just leave *ndevices
> alone when we error out.
>
> Document it as such in the man page, just in case someone accidentally reads
> it.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> CC: Niels Ole Salscheider <niels_ole at salscheider-online.de>
> ---
> Changes to v1:
> - Niels' first patch set ndevices to 0, this one leaves it untouched
>
Slightly split between "doing the right thing" and "the cat is out of
the bag" ;-)

I'm leaning towards the former, although we might want to prod
Chromium devs and/or send them a patch ?

Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
-Emil


More information about the xorg-devel mailing list