[PATCH xf86-input-libinput] Don't init the AccelSpeed/LeftHanded properties on the base tablet device

Eric Engestrom eric.engestrom at imgtec.com
Wed Oct 26 09:13:28 UTC 2016


On Wednesday, 2016-10-26 15:08:23 +1000, Peter Hutterer wrote:
> This device never sends events, no point in exposing these options
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Does what it says on the tin :)
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> ---
>  src/xf86libinput.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xf86libinput.c b/src/xf86libinput.c
> index 8ee6cbe..07b4d4e 100644
> --- a/src/xf86libinput.c
> +++ b/src/xf86libinput.c
> @@ -4092,7 +4092,8 @@ LibinputInitAccelProperty(DeviceIntPtr dev,
>  	enum libinput_config_accel_profile profile;
>  	BOOL profiles[2] = {FALSE};
>  
> -	if (!libinput_device_config_accel_is_available(device))
> +	if (!libinput_device_config_accel_is_available(device) ||
> +	    driver_data->capabilities & CAP_TABLET)
>  		return;
>  
>  	prop_accel = LibinputMakeProperty(dev,
> @@ -4260,7 +4261,8 @@ LibinputInitLeftHandedProperty(DeviceIntPtr dev,
>  {
>  	BOOL left_handed = driver_data->options.left_handed;
>  
> -	if (!libinput_device_config_left_handed_is_available(device))
> +	if (!libinput_device_config_left_handed_is_available(device) ||
> +	    driver_data->capabilities & CAP_TABLET)
>  		return;
>  
>  	prop_left_handed = LibinputMakeProperty(dev,
> -- 
> 2.9.3
> 


More information about the xorg-devel mailing list