[PATCH xserver] configure.ac: bump epoxy requirement to 1.2

Adam Jackson ajax at redhat.com
Wed Oct 26 16:13:15 UTC 2016


On Wed, 2016-10-26 at 11:29 +0100, Emil Velikov wrote:

> Maybe coffee hasn't kicked in, but it does seem to matter.

I did not misspeak, I promise.

> Think about: build against pre 1.2 [epoxy] then run against 1.2 or
> later and you'll get some lovely fireworks.

glamor_egl_screen_private::display is an EGLDisplay, so if you build
against pre-1.2 you will get build-time warnings about type mismatches
where we call epoxy_has_egl_extension. But it will work just fine,
because EGLDisplay is a pointer type anyway, and the pre-1.2 version of
that function is:

PUBLIC bool
epoxy_has_egl_extension(EGLDisplay *dpy, const char *ext)
{
    return epoxy_extension_in_string(eglQueryString(dpy, EGL_EXTENSIONS), ext);
}

Which is to say: epoxy _also_ had a type mismatch warning here.

- ajax


More information about the xorg-devel mailing list