[PATCH xserver] glx: Fix computation of GLX_X_RENDERABLE fbconfig attribute

Eric Anholt eric at anholt.net
Fri Sep 2 22:43:49 UTC 2016


Adam Jackson <ajax at redhat.com> writes:

> From the GLX spec:
>
>     "GLX_X_RENDERABLE is a boolean indicating whether X can be used to
>     render into a drawable created with the GLXFBConfig. This attribute
>     is True if the GLXFBConfig supports GLX windows and/or pixmaps."
>
> Every backend was setting this to true unconditionally, and then the
> core ignored that value and sent true unconditionally on its own. This
> is broken for ARB_fbconfig_float and EXT_fbconfig_packed_float, which
> only apply to pbuffers, which are not renderable from non-GLX APIs.
>
> Instead compute GLX_X_RENDERABLE from the supported drawable types. The
> dri backends were getting _that_ wrong too, so fix that as well.
>
> This is not a functional change, as there are no mesa drivers that claim
> to support __DRI_ATTRIB_{UNSIGNED_,}FLOAT_BIT yet.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160902/31796620/attachment-0001.sig>


More information about the xorg-devel mailing list