[PATCH:xserver] Fix modesetting build when glamor is disabled

Alan Coopersmith alan.coopersmith at oracle.com
Sun Sep 11 03:31:04 UTC 2016


On 09/10/16 11:25 AM, Hans de Goede wrote:
> Hi,
>
> On 10-09-16 20:05, Alan Coopersmith wrote:
>> present.c: In function ‘ms_present_queue_vblank’:
>> present.c:144:31: error: implicit declaration of function ‘ms_flush_drm_events’
>> [-Werror=implicit-function-declaration]
>>          if (errno != EBUSY || ms_flush_drm_events(screen) < 0) {
>>                                ^
>> present.c:144:9: warning: nested extern declaration of ‘ms_flush_drm_events’
>> [-Wnested-externs]
>>          if (errno != EBUSY || ms_flush_drm_events(screen) < 0) {
>>          ^
>>
>> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>
> A fix for this was already posted (and reviewed) a few days ago,
> that fix instead moved the ms_flush_drm_events() implementation
> outside of #ifdef GLAMOR, since it does not depend on GLAMOR,
> which seems like a better fix to me.

Oh great, never mind then - I'd tried searching patchwork for a patch
matching "ms_flush_drm_events" but didn't find one.  I found it searching
the recent patches in:
	https://patchwork.freedesktop.org/patch/108907/
so I guess patchwork search doesn't work the way I'd expected.

I've marked mine rejected in patchwork.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list