[PATCH 2/3] Xext/shm: Better support cases where O_CLOEXEC is not defined

[Julien Cristau]

On Mon, Sep 12, 2016 at 10:53:39 -0700, Jeremy Huddleston Sequoia wrote:

> 
> > On Sep 12, 2016, at 04:33, Julien Cristau <jcristau at debian.org> wrote:
> > 
> > On Sun, Sep 11, 2016 at 20:01:50 -0700, Jeremy Huddleston Sequoia wrote:
> > 
> >> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
> >> ---
> >> Xext/shm.c | 6 +++++-
> >> 1 file changed, 5 insertions(+), 1 deletion(-)
> >> 
> > Does anything have O_TMPFILE but not O_CLOEXEC?
> 
> Not sure, but I figured it'd be good to be on the safe side.  Snow Leopard (OS X 10.6) doesn't have either.  I saw this when making the change to check for O_CLOEXEC in os/inputthread and thought I'd bring it up for consideration.
> 
> If you don't think that O_TMPFILE && !O_CLOEXEC is something we'll see in the wild, I'm happy to just leave it as is.
> 
As far as I know O_TMPFILE is a Linux-ism, so my vote would be for
leaving this as-is until it becomes a problem, if ever.

Cheers,
Julien