[PATCH 1/1] randr: Initialize RandR even if there are currently no screens attached

[Jeremy Huddleston Sequoia]

Ping.

> On Sep 11, 2016, at 02:23, Jeremy Huddleston Sequoia <jeremyhu at apple.com> wrote:
> 
> Failure to do so causes an overvlow in RRClientCallback().
> 
> =================================================================
> ==41262==ERROR: AddressSanitizer: global-buffer-overflow on address 0x000103ccfbc8 at pc 0x0001034f32b9 bp 0x7000035a94c0 sp 0x7000035a94b8
> WRITE of size 4 at 0x000103ccfbc8 thread T6
>    #0 0x1034f32b8 in RRClientCallback randr.c:72
>    #1 0x1038c75e3 in _CallCallbacks dixutils.c:737
>    #2 0x10388f406 in CallCallbacks callback.h:83
>    #3 0x1038bc49a in NextAvailableClient dispatch.c:3562
>    #4 0x103ad094c in AllocNewConnection connection.c:777
>    #5 0x103ad1695 in EstablishNewConnections connection.c:863
>    #6 0x1038c6630 in ProcessWorkQueue dixutils.c:523
>    #7 0x103ab2dbf in WaitForSomething WaitFor.c:175
>    #8 0x103880836 in Dispatch dispatch.c:411
>    #9 0x1038c2141 in dix_main main.c:301
>    #10 0x1032ac75a in server_thread quartzStartup.c:66
>    #11 0x7fffc5f16aaa in _pthread_body (libsystem_pthread.dylib+0x3aaa)
>    #12 0x7fffc5f169f6 in _pthread_start (libsystem_pthread.dylib+0x39f6)
>    #13 0x7fffc5f161fc in thread_start (libsystem_pthread.dylib+0x31fc)
> 
> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
> ---
> randr/randr.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/randr/randr.c b/randr/randr.c
> index 0138dc1..efd3859 100644
> --- a/randr/randr.c
> +++ b/randr/randr.c
> @@ -387,9 +387,6 @@ RRExtensionInit(void)
> {
>     ExtensionEntry *extEntry;
> 
> -    if (RRNScreens == 0)
> -        return;
> -
>     if (!dixRegisterPrivateKey(&RRClientPrivateKeyRec, PRIVATE_CLIENT,
>                                sizeof(RRClientRec) +
>                                screenInfo.numScreens * sizeof(RRTimesRec)))
> -- 
> 2.9.3
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4465 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160916/2b1affbb/attachment-0001.bin>