[PATCH 1/2] os/connection: Call ClientReady() based on a level trigger rather than an edge trigger

Keith Packard keithp at keithp.com
Sun Sep 18 16:58:58 UTC 2016


Matthieu Herrb <matthieu at herrb.eu> writes:

> this doesn't fix an issue I'm seeing on OpenBSD with xterm not beeing
> able to start (it makes the X server spin at 100% CPU in
> WaitForSomething()), while Jeremy's patches do fix the issue for me.

I think Jeremy's patch will cause the server to spin while any client is
not writable, which isn't good.

> I've not been able to really understand the issue yet, but that's a
> data point. (And I'm glad to see that it doesn't seem to be an OpenBSD
> specific issue :)

I'd bet anyone using poll(2) instead of epoll(2) will see the same
problems. It should be possible to reproduce this on Linux by using the
poll path instead of epoll.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160918/0007dbf2/attachment.sig>


More information about the xorg-devel mailing list