[PATCH xf86-input-libinput] Fix --with-xorg-conf-dir default value

Peter Hutterer peter.hutterer at who-t.net
Wed Sep 21 06:49:55 UTC 2016


On Fri, Sep 16, 2016 at 05:26:06PM +0900, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
> 
> If --prefix isn't specified on the command line, $prefix contains "NONE"
> at this point, not the default prefix value. So make install would
> attempt to install the xorg.conf.d snippet to
> ${DESTDIR}NONE/share/X11/xorg.conf.d/.
> 
> Avoid this by leaving ${prefix} verbatim in the default value, to be
> resolved by make.
> 
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

what system was this on? my fedora here seems to fill in the /usr/local prefix
automatically and early enough that this isn't an issue. So I'm wondering if
this a temporary configure bug on your box or a general issue?

Cheers,
   Peter

> ---
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4c72c75..4158e57 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -58,9 +58,9 @@ AC_SUBST(inputdir)
>  
>  AC_ARG_WITH(xorg-conf-dir,
>              AC_HELP_STRING([--with-xorg-conf-dir=DIR],
> -                           [Default xorg.conf.d directory [[default=$prefix/share/X11/xorg.conf.d/]]]),
> +                           [Default xorg.conf.d directory [[default=${prefix}/share/X11/xorg.conf.d]]]),
>              [xorgconfdir="$withval"],
> -            [xorgconfdir="$prefix/share/X11/xorg.conf.d"])
> +            [xorgconfdir='${prefix}/share/X11/xorg.conf.d'])
>  AC_SUBST(xorgconfdir)
>  
>  # X Server SDK location is required to install header files
> -- 
> 2.9.3
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel
> 


More information about the xorg-devel mailing list