[PATCH] remove dead code in dummy driver

Antoine Martin antoine at nagafix.co.uk
Thu Sep 22 05:57:27 UTC 2016


On 22/09/16 03:22, Aaron Plattner wrote:
> On 09/20/2016 02:07 AM, Eric Engestrom wrote:
>> On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote:
>>> Signed-off-by: Antoine Martin <antoine at nagafix.co.uk>
>>
>> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> 
> Looks good to me too (although I'm cheating since this chunk is identical to part of https://patchwork.freedesktop.org/patch/41058/)
That one is even better.

You can add to that one:
Reviewed-by: Antoine Martin <antoine at nagafix.co.uk>

Cheers
Antoine



> 
> Pushed:
> remote: Updating patchwork state for https://patchwork.freedesktop.org/project/Xorg/list/
> remote: I: patch #111435 updated using rev 367c778240b4266958f33cec3653d5389e283557.
> remote: I: 1 patch(es) updated to state Accepted.
> To git+ssh://git.freedesktop.org/git/xorg/driver/xf86-video-dummy
>    8706f60ab457..367c778240b4  HEAD -> master
> 
>>> ---
>>>  src/dummy_driver.c | 19 -------------------
>>>  1 file changed, 19 deletions(-)
>>>
>>> diff --git a/src/dummy_driver.c b/src/dummy_driver.c
>>> index c84000f..ec1acf3 100644
>>> --- a/src/dummy_driver.c
>>> +++ b/src/dummy_driver.c
>>> @@ -700,25 +700,6 @@ DUMMYSwitchMode(SWITCH_MODE_ARGS_DECL)
>>>  void
>>>  DUMMYAdjustFrame(ADJUST_FRAME_ARGS_DECL)
>>>  {
>>> -    SCRN_INFO_PTR(arg);
>>> -    int Base; 
>>> -
>>> -    Base = (y * pScrn->displayWidth + x) >> 2;
>>> -
>>> -    /* Scale Base by the number of bytes per pixel. */
>>> -    switch (pScrn->depth) {
>>> -    case  8 :
>>> -	break;
>>> -    case 15 :
>>> -    case 16 :
>>> -	Base *= 2;
>>> -	break;
>>> -    case 24 :
>>> -	Base *= 3;
>>> -	break;
>>> -    default :
>>> -	break;
>>> -    }
>>>  }
>>>  
>>>  /* Mandatory */
>>> -- 
>>> 2.7.4
> 



More information about the xorg-devel mailing list