[PATCH xserver] xf86_crtc_supports_gamma: Return FALSE if RandR is disabled

Mariusz Bialonczyk manio at skyboo.net
Thu Apr 6 19:30:55 UTC 2017


On Thu, 6 Apr 2017 15:15:00 +0900
Michel Dänzer <michel at daenzer.net> wrote:

> On 06/04/17 12:27 PM, Alex Deucher wrote:
> > On Wed, Apr 5, 2017 at 11:23 PM, Michel Dänzer <michel at daenzer.net> wrote:
> >> From: Michel Dänzer <michel.daenzer at amd.com>
> >>
> >> E.g. becuase Xinerama is enabled.
> >>
> >> Fixes crash on server startup when RandR is disabled and all other
> >> conditions in xf86_crtc_supports_gamma are satisfied.
> >>
> >> Bugzilla: https://bugs.freedesktop.org/100293
> >> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> > 
> > Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> 
> Thanks, Alex. However, after thinking about this bug and related
> https://bugs.freedesktop.org/show_bug.cgi?id=100294 some more, I suspect
> we might end up needing a different fix.

Tested-by: Mariusz Bialonczyk <manio at skyboo.net>

FWIW: the patch indeed fixes the xorg crash

Regarding bug #100294, I've added a photo from monitors, for you to see
what I am talking about:
https://bugs.freedesktop.org/attachment.cgi?id=130733
https://bugs.freedesktop.org/attachment.cgi?id=130734
In the same time the third monitor was constantly black, only cursor
was visible. Moving a window to this screen shows nothing (black) - maybe
the gamma was set to zero, or something like this?

Of course when I did a screenshot from xorg, all is fine:
https://bugs.freedesktop.org/attachment.cgi?id=130735

regards,
-- 
Mariusz Białończyk | xmpp/e-mail: manio at skyboo.net
http://manio.skyboo.net | https://github.com/manio


More information about the xorg-devel mailing list