[PATCH] release.sh: redefine GPGKEY if already existing

Peter Hutterer peter.hutterer at who-t.net
Tue Apr 18 02:08:19 UTC 2017


On Fri, Apr 07, 2017 at 04:26:35PM +0300, Andres Gomez wrote:
> GPGKEY may already exist in the environment. In that case, just
> redefine it adding "-u"

Is GPGKEY a common thing used in other scripts? I honestly don't know. If
not, then I wonder if redefining it is risky to pick the wrong key and it
may be better to just zero it out, requiring the use of --gpgkey for th
release script.

Cheers,
   Peter

> 
> Signed-off-by: Andres Gomez <agomez at igalia.com>
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Cc: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  release.sh | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/release.sh b/release.sh
> index f976f94..e5e699d 100755
> --- a/release.sh
> +++ b/release.sh
> @@ -808,6 +808,11 @@ if [ "x$GPG" = "x" ] ; then
>      fi
>  fi
>  
> +# Redefine GPGKEY if needed
> +if [ "x$GPGKEY" != "x" ] ; then
> +    GPGKEY="-u $GPGKEY"
> +fi
> +
>  # Set the default make tarball creation command
>  MAKE_DIST_CMD=distcheck
>  
> -- 
> 2.11.0
> 


More information about the xorg-devel mailing list