[PATCH util-modular v3] release.sh: unconditionally unset GPGKEY

Peter Hutterer peter.hutterer at who-t.net
Thu Apr 20 23:46:17 UTC 2017


On Thu, Apr 20, 2017 at 10:38:03AM +0300, Andres Gomez wrote:
> GPGKEY may already exist in the environment. Unconditionally unset it
> to avoid any problem.
> 
> v2: unsetting is safer than redefining to quietly use a potentially
>     wrong key stored in the variable (Peter).
> v3: Simplify by unconditionally unsetting GPGKEY (Peter).
> 
> Signed-off-by: Andres Gomez <agomez at igalia.com>
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Cc: Peter Hutterer <peter.hutterer at who-t.net>

Thanks!

remote: I: patch #151386 updated using rev 5e213276183aae1bb8d192d74322ac0990c388ae.
remote: I: 1 patch(es) updated to state Accepted.
To git+ssh://git.freedesktop.org/git/xorg/util/modular
   ac00c5e..5e21327  master -> master


Cheers,
   Peter

> ---
>  release.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/release.sh b/release.sh
> index f976f94..ff89d2e 100755
> --- a/release.sh
> +++ b/release.sh
> @@ -808,6 +808,9 @@ if [ "x$GPG" = "x" ] ; then
>      fi
>  fi
>  
> +# Avoid problems if GPGKEY is already set in the environment
> +unset GPGKEY
> +
>  # Set the default make tarball creation command
>  MAKE_DIST_CMD=distcheck
>  
> -- 
> 2.11.0
> 


More information about the xorg-devel mailing list