[PATCH xserver] glamor: an FBO is not needed for Xv pixmaps

[Eric Anholt]

Olivier Fourdan <ofourdan at redhat.com> writes:

> It appears that on some hardware/diver combo such as nv30/nouveau, using
> GL_ALPHA as format for 8-bit depth will cause an incomplete attachment
> error (GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT) when trying to bind the
> texture.
>
> As a result, the FBO is NULL and glamor segfaults when trying to access
> the FBO width/height in pixmap_priv_get_scale() in glamor_xv_render().
>
> This happens with glamor-xv which uses 8-bit pixmaps, meaning that on
> such hardware/driver, trying to play a video using Xv will lead to a
> crash of the Xserver. This affects Xwayland, Xephyr, modesetting driver
> with glamor accel.
>
> But the use of an FBO is not actually needed for glamox-xv, so by
> disabling FBO at pixmap creation, we can avoid the issue entirely.
>
> Fix suggested by Eric Anholt <eric at anholt.net>
>
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=100710
> Fixes: https://bugzilla.redhat.com/1412814

Reviewed and pushed.  Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170421/371174c7/attachment.sig>