[PATCH xproto] Add XF86XK_Keyboard

[Peter Hutterer]

On Fri, Apr 21, 2017 at 10:38:42AM +0200, Christian Kellner wrote:
> 
> > We are not XFree86, and are not adding new XF86 keysyms as the note
> > at the top of XF86keysym.h says. Instead keysyms should be added to
> > keysymdef.h and the files listed in the big comment at the top of it.
> 
> I did indeed see the 'big comment' while making the change, but when I 
> looked for a good place in keysymdef.h to put this key nothing obvious
> seemed like the right place. The "Misc functions" group doesn't seem to
> have any values left to use. Maybe a new group in the "XK_XKB_KEYS"
> section?
> 
> While discussing this issue (on IRC) with Daniel Stone and a few others
> it was pointed out that the intention to not add symbols toXF86keysym.h
>   might be a relict from era where XFree86 was still "more active" (to
> put it nicely). So still in doubt after all the discussions I decided
> to put it in XF86keysym.h was the easiest and despite "the big comment"
> maybe still the best option; mainly I wanted to get advice where to
> exactly put this keysym (and future ones as there might be more like
> this key in the near future since there are quite a few umapped input
> key events).

I agree, I think we can stop caring about 'XFree86 owns that scope' and
should just add them where it's make sense. All the other special symbols
are in there, many of those added after the split (and the proportion of
users who even know what xfree86 was is shrinking too). 

So unless Alan has any serious objections, I'll go ahead and push this patch
in the next day or two.

Cheers,
   Peter